Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use initial_properties #6

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Use initial_properties #6

merged 3 commits into from
Sep 30, 2023

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Sep 23, 2023

  • Use initial_properties
  • Remove some obsolete files

@Niklp09 Niklp09 added the enhancement New feature or request label Sep 23, 2023
@wsor4035
Copy link

if you want to remove the copyright files fine, but information should be moved to the license file

wsor4035
wsor4035 approved these changes Sep 30, 2023
View reviewed changes
Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably copyright.txt->license[.extenion], otherwise seems good

@Niklp09
Copy link
Member Author

Niklp09 commented Sep 30, 2023

Already taken by LICENSE.txt (LGPL 3.0 copy)

@wsor4035
Copy link

wsor4035 commented Sep 30, 2023 •
edited
Loading

Already taken by LICENSE.txt (LGPL 3.0 copy)

License: GPL v3

hmm.......

wsor4035
wsor4035 approved these changes Sep 30, 2023
View reviewed changes
Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough for now, still an improvement

@wsor4035 wsor4035 merged commit e25588c into master Sep 30, 2023
2 checks passed
@Niklp09 Niklp09 deleted the initial_properties branch September 30, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsor4035 wsor4035 wsor4035 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Niklp09 @wsor4035